Since trunk is going to be 3.0-SNAPSHOT in between alphas, I needed to
take a slightly different approach. In that case (,3.0-alpha-1) will
still trigger it, but [3.0-alpha-2,) will not (for those issues that
are later fixed).
What I did was changed the IT base class to ignore -SNAPSHOT - it's
irrelevant to the range consideration and allows us to be clearer (eg,
use [2.0.10,) instead of (2.0.9,) for "fixed in 2.0.10").
The drawback is that trunk is going to be considered, for example, >=
3.0-alpha-4 even if alpha-3 isn't released. So instead of putting
range assumptions in there, I just left "TODO" notes to make those ITs
work again on 3.0, and comments that an IT won't be fixed for 3.0 for
those that won't be due to a change in functionality (extensions). I
think that's more accurate anyway.
However, here are the tests that fail for me on alpha-2 - is this an
expected state, or have I got something wrong? The ones marked with
(*) did not fail with alpha-1 (though there are a great many more that
pass that didn't before). Should the ranges be updated to accommodate
these?
Failed tests:
testitMNG4009
(org.apache.maven.it.MavenITmng4009InheritProfileEffectsTest)
testitMNG4008(org.apache.maven.it.MavenITmng4008MergedFilterOrderTest)
testitMNG3947
(org.apache.maven.it.MavenITmng3947PluginDefaultExecutionConfigTest)
(*)
testitWithoutPluginMngt
(org.apache.maven.it.MavenITmng3938MergePluginExecutionsTest)
testitWithoutPluginMngt
(org.apache.maven.it.MavenITmng3925MergedPluginExecutionOrderTest)
testitWithPluginMngt
(org.apache.maven.it.MavenITmng3925MergedPluginExecutionOrderTest)
testitMNG3906
(org.apache.maven.it.MavenITmng3906MergedPluginClassPathOrderingTest)
testitMNG3900
(org.apache.maven.it.MavenITmng3900ProfilePropertiesInterpolationTest)
testitMNG3877(org.apache.maven.it.MavenITmng3877BasedirAlignedModelTest)
testitMNG3836
(org.apache.maven.it.MavenITmng3836PluginConfigInheritanceTest)
testitMNG3819
(org.apache.maven.it.MavenITmng3819PluginDepPlexusUtilsTest)
testitMNG3769
(org.apache.maven.it.MavenITmng3769ExclusionRelocatedTransdepsTest)
testitMNG3680
(org.apache.maven.it.MavenITmng3680InvalidDependencyPOMTest)
testitMNG3099
(org.apache.maven.it.MavenITmng3099SettingsProfilesWithNoPomTest)
testitMNG2591
(org.apache.maven.it.MavenITmng2591MergeInheritedPluginConfigTest)
testitMNG2006
(org.apache.maven.it.MavenITmng2006ChildPathAwareUrlInheritanceTest)
testitBuildConfigIrrelevantForReports
(org.apache.maven.it.MavenITmng0469ReportConfigTest)
testitMNG0249
(org.apache.maven.it.MavenITmng0249ResolveDepsFromReactorTest)
testit0040(org.apache.maven.it.MavenIT0040Test)
Tests in error:
testitFromPom
(org.apache.maven.it.MavenITmng3948ParentResolutionFromProfileReposTest)
testitFromProfilesXml
(org.apache.maven.it.MavenITmng3948ParentResolutionFromProfileReposTest)
(*)
testitWithPluginMngt
(org.apache.maven.it.MavenITmng3938MergePluginExecutionsTest)
(*)
testitWithPluginMngt
(org.apache.maven.it.MavenITmng3937MergedPluginExecutionGoalsTest)
testitNonUniqueVersionReactor
(org.apache.maven.it.MavenITmng3885UniqueVersionFromParentProfileTest)
testitNonUniqueVersionStandalone
(org.apache.maven.it.MavenITmng3885UniqueVersionFromParentProfileTest)
testitUniqueVersionReactor
(org.apache.maven.it.MavenITmng3885UniqueVersionFromParentProfileTest)
testitUniqueVersionStandalone
(org.apache.maven.it.MavenITmng3885UniqueVersionFromParentProfileTest)
(*)
testitMNG3679
(org.apache.maven.it.MavenITmng3679PluginExecIdInterpolationTest)
testitMNG3372
(org.apache.maven.it.MavenITmng3372DirectInvocationOfPluginsTest)
testDependencyTreeInvocation
(org.apache.maven.it.MavenITmng3372DirectInvocationOfPluginsTest)
testitMNG2926(org.apache.maven.it.MavenITmng2926PluginPrefixOrderTest)
testParentUnresolvable
(org.apache.maven.it.MavenITmng2883LegacyRepoOfflineTest)
testPluginUnresolvable
(org.apache.maven.it.MavenITmng2883LegacyRepoOfflineTest)
testitMNG2052
(org
.apache
.maven.it.MavenITmng2052InterpolateWithSettingsProfilePropertiesTest)
testitMNG0870
(org.apache.maven.it.MavenITmng0870ReactorAwarePluginDiscoveryTest)
testitMNG471(org.apache.maven.it.MavenITmng0471CustomLifecycleTest)
testitMNG377
(org.apache.maven.it.MavenITmng0377PluginLookupFromPrefixTest)
testit0041(org.apache.maven.it.MavenIT0041Test)
testit0007(org.apache.maven.it.MavenIT0007Test)
Cheers,
Brett
On 30/01/2009, at 1:48 AM, Brian Fox wrote:
The range should simply skip 3.0alpha1 and 2
--Brian (mobile)
On Jan 29, 2009, at 12:45 AM, Arnaud HERITIER <[email protected]>
wrote:
What i understand in brett's email is that its patches are for 2.1
branch
but he would like to add ITs to check those fixes in 2.1. His
question seems
to be if he has to activate those ITs for 3.0 also ?
Personnaly I would say yes but perhaps not now if you are preparing
an
alpha2. Perhaps it can be a task to fix in alpha3 ?
On Thu, Jan 29, 2009 at 5:28 AM, Jason van Zyl
<[email protected]> wrote:
On 28-Jan-09, at 6:28 PM, Brett Porter wrote:
Hi,
I'm just committing a bunch of fixes. Each has the corresponding
integration test, but since some were in profiles, for example, I
haven't
attempted to merge anything to trunk.
Please don't push anything to trunk, I'll pull in anything in the
alpha-3.
We're about to cut the alpha-2.
Any opinions on how to set the version in the IT? Should it stop at
2.99.99 and come back to check later, or leave it open to include
3.0 and
work to apply them?
Cheers,
Brett
--
Brett Porter
[email protected]
http://blogs.exist.com/bporter/
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
jason at sonatype dot com
----------------------------------------------------------
Three may keep a secret if two of them are dead.
-- Benjamin Franklin
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
--
Arnaud
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
--
Brett Porter
[email protected]
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
