Why don't we just hookup checkstyle to maven?
-----Original Message-----
From: Hervé BOUTEMY [mailto:[email protected]]
Sent: Thursday, February 19, 2009 7:08 PM
To: [email protected]
Subject: Re: svn commit: r746002 - in /maven/components/trunk:
maven-core/src/main/java/org/apache/maven/plugin/
maven-embedder/src/main/java/org/apache/maven/embedder/ maven-project-builder/
maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma
Hi Shane,
There are a lot of coding style conventions problems in this commit:
- whitespace,
- implements/throws on a separate line,
> + private String parentGroupId = null, parentArtifactId = null,
> parentVersion = null, parentId = null, parentRelativePath;
each attribute should be declared on it own line
> -import java.io.File;
> -import java.io.IOException;
> +import java.io.*;
no wildcard imports
> + finally
> + {
> + if ( out != null )
> + {
> + out.close();
> + }
> + }
prefer IOUtil.close( out ) from plexus-utils, which has the necessary
try/catch to enforce safe code in any cases (I know this case is in-memory,
then not absolutely necessary)
Regards,
Hervé
Le jeudi 19 février 2009, [email protected] a écrit :
> Author: sisbell
> Date: Thu Feb 19 21:22:46 2009
> New Revision: 746002
>
> URL: http://svn.apache.org/viewvc?rev=746002&view=rev
> Log:
> Refactored out more uses of modello and moved classes from maven-project to
> maven-project-builder. Doing this so that maven-mercury will not have
> direct dependency on modello or maven model.
>
[SNAP]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
