I'll take a look but I'm generally in favor of using Maven to do these things rather than duplicating the effort over again in Hudson specific config.
-----Original Message----- From: Vincent Siveton [mailto:vincent.sive...@gmail.com] Sent: Saturday, February 21, 2009 8:45 AM To: Maven Developers List Subject: Re: svn commit: r746002 - in /maven/components/trunk: maven-core/src/main/java/org/apache/maven/plugin/ maven-embedder/src/main/java/org/apache/maven/embedder/ maven-project-builder/ maven-project-builder/src/main/java/org/apache/maven/project/builde +1 Vincent 2009/2/21, Hervé BOUTEMY <herve.bout...@free.fr>: > oh yes, something like Violations Hudson plugin [1] for example would be a > great enhancement, since this would be on a central machine and give history. > Definitely helpful and should not be too complicated to add to existing CI > instances. > I'm not a Hudson expert, nor do I really know this plugin: I found it in > Apache's Hudson instance then read the manual, I even not tried it. If > anybody knows another plugin, no problem for me: for example, just found > another one [2] that seems quite equivalent. > > There is still one feature missing: automatic blame when reports get worse on > a commit. I didn't find anything like this. > > Regards, > > Hervé > > > [1] http://wiki.hudson-ci.org/display/HUDSON/Violations > > [2] http://wiki.hudson-ci.org/display/HUDSON/Static+Code+Analysis+Plug-ins > > Le vendredi 20 février 2009, Brian E. Fox a écrit : > > > Ok, I mean either enable it all the time, or get some reports or CI etc. > > > > -----Original Message----- > > From: Dennis Lundberg [mailto:denn...@apache.org] > > Sent: Friday, February 20, 2009 11:26 AM > > To: Maven Developers List > > Subject: Re: svn commit: r746002 - in /maven/components/trunk: > > maven-core/src/main/java/org/apache/maven/plugin/ > > maven-embedder/src/main/java/org/apache/maven/embedder/ > > maven-project-builder/ > > maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma > > > > We already have it in the Maven parent POM. > > > > When using the "reporting" profile you get a Checkstyle report for the > > current artifact. > > > > Brian E. Fox wrote: > > > Why don't we just hookup checkstyle to maven? > > > > > > -----Original Message----- > > > From: Hervé BOUTEMY [mailto:herve.bout...@free.fr] > > > Sent: Thursday, February 19, 2009 7:08 PM > > > To: dev@maven.apache.org > > > Subject: Re: svn commit: r746002 - in /maven/components/trunk: > > > maven-core/src/main/java/org/apache/maven/plugin/ > > > maven-embedder/src/main/java/org/apache/maven/embedder/ > > > maven-project-builder/ > > > maven-project-builder/src/main/java/org/apache/maven/project/builder/ ma > > > > > > Hi Shane, > > > > > > There are a lot of coding style conventions problems in this commit: > > > - whitespace, > > > - implements/throws on a separate line, > > > > > >> + private String parentGroupId = null, parentArtifactId = null, > > >> parentVersion = null, parentId = null, parentRelativePath; > > > > > > each attribute should be declared on it own line > > > > > >> -import java.io.File; > > >> -import java.io.IOException; > > >> +import java.io.*; > > > > > > no wildcard imports > > > > > >> + finally > > >> + { > > >> + if ( out != null ) > > >> + { > > >> + out.close(); > > >> + } > > >> + } > > > > > > prefer IOUtil.close( out ) from plexus-utils, which has the necessary > > > try/catch to enforce safe code in any cases (I know this case is > > > in-memory, then not absolutely necessary) > > > > > > > > > Regards, > > > > > > Hervé > > > > > > Le jeudi 19 février 2009, sisb...@apache.org a écrit : > > >> Author: sisbell > > >> Date: Thu Feb 19 21:22:46 2009 > > >> New Revision: 746002 > > >> > > >> URL: http://svn.apache.org/viewvc?rev=746002&view=rev > > >> Log: > > >> Refactored out more uses of modello and moved classes from maven-project > > >> to maven-project-builder. Doing this so that maven-mercury will not have > > >> direct dependency on modello or maven model. > > > > > > [SNAP] > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
