From what Lukas pointed out it's further down in the Doxia tools that
uses the project builder. I'll go digging but I'm certain you don't
need the signature you're using.
On 15-May-09, at 5:12 PM, Vincent Siveton wrote:
Hi Jason,
Thanks for your log.
Yes I think your changes are corrects. Could you please merge them to
the branch too [1]?
Cheers,
Vincent
[1]
https://svn.apache.org/repos/asf/maven/plugins/branches/maven-site-plugin-doxia-1.1
2009/5/15 <[email protected]>:
Author: jvanzyl
Date: Fri May 15 15:06:30 2009
New Revision: 775177
URL: http://svn.apache.org/viewvc?rev=775177&view=rev
Log:
o Dennis, Vincent and Lukas, I have removed the reference to the
MavenProjectBuilder here and all tests seem to pass. I am trying to
reduce the signature foot print of the MavenProjectBuilder and
older versions of the site plugin (or underlying tools like doxia)
seem to use:
MavenProject build( File project, ArtifactRepository
localRepository, ProfileManager profileManager )
throws ProjectBuildingException;
If I can get rid of that signature I want to because I don't want
to get rid of the ProfileManager from any public signatures.
Could you guys verify this is ok to remove, if so then I will take
this method out from the public signature of the project builder.
Modified:
maven/plugins/trunk/maven-site-plugin/src/main/java/org/apache/
maven/plugins/site/AbstractSiteMojo.java
Modified: maven/plugins/trunk/maven-site-plugin/src/main/java/org/
apache/maven/plugins/site/AbstractSiteMojo.java
URL:
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/AbstractSiteMojo.java?rev=775177&r1=775176&r2=775177&view=diff
=
=
=
=
=
=
=
=
=
=====================================================================
--- maven/plugins/trunk/maven-site-plugin/src/main/java/org/apache/
maven/plugins/site/AbstractSiteMojo.java (original)
+++ maven/plugins/trunk/maven-site-plugin/src/main/java/org/apache/
maven/plugins/site/AbstractSiteMojo.java Fri May 15 15:06:30 2009
@@ -32,7 +32,6 @@
import org.apache.maven.doxia.tools.SiteTool;
import org.apache.maven.plugin.AbstractMojo;
import org.apache.maven.project.MavenProject;
-import org.apache.maven.project.MavenProjectBuilder;
import org.apache.maven.reporting.MavenReport;
import org.codehaus.plexus.i18n.I18N;
import org.codehaus.plexus.util.ReaderFactory;
@@ -101,13 +100,6 @@
protected List reactorProjects;
/**
- * Project builder
- *
- * @component
- */
- protected MavenProjectBuilder mavenProjectBuilder;
-
- /**
* Specifies the input encoding.
*
* @parameter expression="${encoding}" default-value="$
{project.build.sourceEncoding}"
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------
A language that doesn’t affect the way you think about programming is
not worth knowing.
-— Alan Perlis
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
