+1 it's a simple trade off. Do we like to punish >=jdk1.5 users or <=jdk1.4 users. For a production build or in a CI system, plugin versions should be set in the pom anyway. Otherwise a build is not 100% reproduceable.
LieGrue, strub ----- Ursprüngliche Mail ---- > Von: Brett Porter <[email protected]> > An: Maven Developers List <[email protected]> > Gesendet: Samstag, den 16. Mai 2009, 03:12:56 Uhr > Betreff: Re: [VOTE] Java 5 and Maven Plugins > > > On 16/05/2009, at 5:06 AM, Stephane Nicoll wrote: > > > On Fri, May 15, 2009 at 6:58 PM, Benjamin Bentmann < > > [email protected]> wrote: > > > >> Daniel Kulp wrote: > >> > >> On Fri May 15 2009 12:18:59 pm Brian Fox wrote: > >>> > >>>> I don't think we should go out of our way yet to convert everything to > >>>> java5, preserving 1.4 compatibility (essentially 2.0/2.1 compatibility) > >>>> should be considered. However if there's a reason, like the checkstyle > >>>> update requies java 5, then we should do it and set a prerequisite of > >>>> maven > >>>> 2.2.0. > >>>> > >>> > >>> I don't think setting a prerequisite of 2.2.0 is a good idea. If the > >>> plugin will work with 2.0.10 + java 5, then I think we should allow that. > >>> > >> > >> I agree with Dan, the prerequisite on a specific Maven version and a Java > >> version are two different things. Users can fairly well run plugins > >> targetting Java 1.5 with a core targetting 1.4. > > > > > > +1 > > +1, including Brian's original sentiment. Be conservative but not restrictive. > > As long as it is clearly documented in the plugin release notes / site (and > the > last version to work with 1.4 should be indicated), I think we can live with > the > occasional auto-upgrade biting people using JDK 1.4 and having to lock down a > version. > > In terms of Dennis' suggestions, I would say my choice is that [B] is best, > [A] > is acceptable. > > Cheers, > Brett > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
