-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Ralph,

>>
>> Okay. So thats what I guessed when I said that the MavenProject/Model is
>> just a stupid POJO and various plugins manipulate it with side effects.
>> Sounds a little hacky to me but thats the way it is. So my serialization
>> idea is nuts though.
>>
>> Anyhow I think that if you have some information in memory, you should
>> NOT have to write it to the disc so that someone else can copy (read
>> and write)
>> it again. I thought that you store the transformed XML in that new string
>> attribute (was it alternativeRepresentation) so the Installer/Deployer
>> could write this string if available instead of copying the pom.xml as
>> is.
> 
> I think you are referring to one of the other patches that was
> submitted, not what I committed to the MNG-624 branch.
>>
>>
>> A big problem could be the encoding issue if you store XML in a string
>> and then want to save it with some Writer, you need to know the encoding
>> from the XML-header or you run into trouble.
> 
> My fix didn't store the XML in a string, it modified the DOM.
> 
After getting more of the big picture, I think your idea is good to
write a new pom.xml to ${project.build.directory} and copy that on
install/deploy. This would also solve the needs behind something like
MINSTALL-50 (e.g. by some plugin that does a post-transformation on the new 
pom).

Regards
  Jörg
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkoPJrQACgkQmPuec2Dcv/+ZMwCeNp/rE8KTH0sNeVuDHQ1zeOuD
mtYAn0B6p8XlqT7oan9na/POHJ4LZ4qW
=JvQY
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to