Hi Vincent,
Author: vsiveton
Date: Mon Jul 6 12:38:12 2009
New Revision: 791464
URL: http://svn.apache.org/viewvc?rev=791464&view=rev
Log:
o added MavenOpts for the invoker
Modified:
maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractFixJavadocMojo.java
maven/plugins/trunk/maven-javadoc-plugin/src/test/java/org/apache/maven/plugin/javadoc/FixJavadocMojoTest.java
Modified:
maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractFixJavadocMojo.java
URL:
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractFixJavadocMojo.java?rev=791464&r1=791463&r2=791464&view=diff
==============================================================================
---
maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractFixJavadocMojo.java
(original)
+++
maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractFixJavadocMojo.java
Mon Jul 6 12:38:12 2009
@@ -665,6 +665,8 @@
InvocationOutputHandler outputHandler = new PrintStreamHandler( ps,
false );
request.setOutputHandler( outputHandler );
request.setDebug( true );
+ request.setMavenOpts( "-Xms256m -Xmx256m" );
+
String clirrGoal = getFullClirrGoal();
request.setGoals( Collections.singletonList( clirrGoal ) );
This looks dangerous: What if my project requires more memory to run
Clirr? Then I would be stuck. There might also be other stuff that a
user has configured for MAVEN_OPTS and expects to be effective.
Why not simply pass the MAVEN_OPTS from the current process through to
the forked one (this should be the default behavior IIRC)? Otherwise I
would expect this setting to be at least configurable. Or do I miss an
existing way for a user to adjust this setting?
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
