Brett Porter schrieb:

As the resolution is only needed for the release poms which are off by default, 
in hindsight I don't think we should have added it. Would the following be 
workable?
1) Remove the resolution tag from prepare
2) Add a new mojo :prepare-full, that extends prepare and adds the resolution  
tag
3) Add a warning in :prepare if you use generateReleasePoms = true without 
calling prepare-full

Sounds OK in general, I'm just not sure whether a mere warning in 3) is enough. Consider somebody currently using generateReleasePoms=true and updating to the new plugin version. As far as I understand MRELEASE-240, the release-pom.xml will be broken/incomplete then. What happens if the user misses the warning, will the build fail with same strange error later on or will it just deploy gargabe?

Alternatively, we could add the mojo the other way around, giving less 
disruption to the current behaviour while making it possible to prepare without 
the resolution. It just seems back to front though :)

IIRC, there are other problems with the release POMs so I wouldn't recommend there usage by default and am in favor of your original proposal to drop the anno from the prepare goal.


Benjamin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to