I'll have a look at it in a few days thank you for this patch Regards,
Hervé Le mercredi 28 avril 2010, Marco Rico-Gomez a écrit : > Hi all, > > I've submitted a minor patch for > http://jira.codehaus.org/browse/ARCHETYPE-202, which prevents users to run > mvn archetype:generate -DarchetypeCatalog=http://example.com if they are > behind a http proxy. > > I'd like to ask if someone could review it. > > The "download logic" is implemented three times in the class and I had to > modify all of them. It might be better to encapsulate this functionality > in a private function to avoid code duplication. > > Thanks in advance! > > - Marco > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
