When running mvn eclipse:eclipse on our projects, we cringe with the amount of unnecessary output the plugin generates.
We use source dependencies in our IDE which provide the javadocs, so we have disabled downloading of Javadoc files. Unfortunately, MECLIPSE finds it necessary to report all dependencies for which it hasn't downloaded the javadoc resource jars. I'm trying to come up with a good patch for this and suggest that the plugin remains silent for both missing source and javadoc jars when either option is disabled. It strikes me as odd that when you disable an option, the plugin starts to tell you that things haven't been downloaded, even when you explicitly told it not to download. The main reason I'm asking here is to see if there's a specific need for reporting those missing -javadoc jars, even when their downloading is explicitly disabled. To make things concrete: I'm proposing the following patch (also attached to http://jira.codehaus.org/browse/MECLIPSE-669). Index: src/main/java/org/apache/maven/plugin/ide/AbstractIdeSupportMojo.java =================================================================== --- src/main/java/org/apache/maven/plugin/ide/AbstractIdeSupportMojo.java (revision 992964) +++ src/main/java/org/apache/maven/plugin/ide/AbstractIdeSupportMojo.java (working copy) @@ -1040,16 +1040,9 @@ { StringBuffer msg = new StringBuffer(); - if ( !missingSourceDependencies.isEmpty() ) + if ( getDownloadSources() && !missingSourceDependencies.isEmpty() ) { - if ( getDownloadSources() ) - { - msg.append( Messages.getString( "AbstractIdeSupportMojo.sourcesnotavailable" ) ); //$NON-NLS-1$ - } - else - { - msg.append( Messages.getString( "AbstractIdeSupportMojo.sourcesnotdownloaded" ) ); //$NON-NLS-1$ - } + msg.append( Messages.getString( "AbstractIdeSupportMojo.sourcesnotavailable" ) ); //$NON-NLS-1$ for ( Iterator it = missingSourceDependencies.iterator(); it.hasNext(); ) { @@ -1059,16 +1052,9 @@ msg.append( "\n" ); //$NON-NLS-1$ } - if ( !missingJavadocDependencies.isEmpty() ) + if ( getDownloadJavadocs() && !missingJavadocDependencies.isEmpty() ) { - if ( getDownloadJavadocs() ) - { - msg.append( Messages.getString( "AbstractIdeSupportMojo.javadocnotavailable" ) ); //$NON-NLS-1$ - } - else - { - msg.append( Messages.getString( "AbstractIdeSupportMojo.javadocnotdownloaded" ) ); //$NON-NLS-1$ - } + msg.append( Messages.getString( "AbstractIdeSupportMojo.javadocnotavailable" ) ); //$NON-NLS-1$ for ( Iterator it = missingJavadocDependencies.iterator(); it.hasNext(); ) { Martijn --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
