+1 BTW I wonder why you create NOTICE files manually ? maven-remote-resources-plugin is your friend, if you have missing infos as in this case with tango etc. See [1].
-- Olivier Lamy Talend: http://coders.talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy [1] http://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html 2011/11/23 Simone Tripodi <simonetrip...@apache.org>: > Hi Ralph, > debugging I just discovered that the maven-shared-archive-resources is > the responsible for including the doubled resources - need to figure > out how to exclude it :) > Thanks again for reviewing! > Simo > > [DEBUG] copy > /Users/simonetripodi/Documents/workspace/maven-fluido-skin/target/maven-shared-archive-resources/META-INF/DEPENDENCIES > to > /Users/simonetripodi/Documents/workspace/maven-fluido-skin/target/classes/META-INF/DEPENDENCIES > [DEBUG] file LICENSE has a filtered file extension > [DEBUG] copy > /Users/simonetripodi/Documents/workspace/maven-fluido-skin/target/maven-shared-archive-resources/META-INF/LICENSE > to > /Users/simonetripodi/Documents/workspace/maven-fluido-skin/target/classes/META-INF/LICENSE > [DEBUG] file NOTICE has a filtered file extension > [DEBUG] copy > /Users/simonetripodi/Documents/workspace/maven-fluido-skin/target/maven-shared-archive-resources/META-INF/NOTICE > to > /Users/simonetripodi/Documents/workspace/maven-fluido-skin/target/classes/META-INF/NOTICE > > http://people.apache.org/~simonetripodi/ > http://simonetripodi.livejournal.com/ > http://twitter.com/simonetripodi > http://www.99soft.org/ > > > > On Wed, Nov 23, 2011 at 8:57 PM, Simone Tripodi > <simonetrip...@apache.org> wrote: >> Hi Ralph!!! >> I was sure to have removed duplicate files LICENSE/NOTICE files, >> instead they mysteriously came back... I need to figure out where they >> came from :O >> Looks like release notes are not used here, usually people list the >> fixed JIRA issues - empty ATM. >> Thanks for reviewing, all the best!!! >> Simo >> >> http://people.apache.org/~simonetripodi/ >> http://simonetripodi.livejournal.com/ >> http://twitter.com/simonetripodi >> http://www.99soft.org/ >> >> >> >> On Wed, Nov 23, 2011 at 7:38 PM, Ralph Goers <ralph.go...@dslextreme.com> >> wrote: >>> +1 >>> >>> I didn't do an exhaustive review. The skin itself works fine in the project >>> I've added it to. I verified the source zip builds. There aren't any >>> release notes but I'm not sure that is required. I did notice that there is >>> a NOTICE file and a NOTICE.txt file that are not identical. I'm not sure >>> why both are needed. NOTICE.txt lists a couple of items that don't show up >>> as dependencies with dependency:tree. I'm not sure if that is an error or >>> not. There is also a LICENSE file and a LICENSE.txt file that are >>> identical. I'm not sure why both are needed. >>> >>> Ralph >>> >>> On Nov 23, 2011, at 6:54 AM, Simone Tripodi wrote: >>> >>>> Hi all Maven fellows, >>>> I'm here to propose the first official release of Apache Maven Fluido Skin >>>> :) >>>> That's my first Maven release so apologize in advance for any possible >>>> mistake :P >>>> Thanks in advance for reviewing! >>>> Simo >>>> Staging repo: >>>> https://repository.apache.org/content/repositories/maven-236/ >>>> Staging site:http://maven.apache.org/skins/maven-fluido-skin/ >>>> Guide to testing staged >>>> releases:http://maven.apache.org/guides/development/guide-testing-releases.html >>>> Vote open for 72 hours, will be closed on Nov 26th, 2011, at 2:00pm CET >>>> [ ] +1[ ] +0[ ] -1 >>>> >>>> http://people.apache.org/~simonetripodi/ >>>> http://simonetripodi.livejournal.com/ >>>> http://twitter.com/simonetripodi >>>> http://www.99soft.org/ >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> For additional commands, e-mail: dev-h...@maven.apache.org >>> >>> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
