+1 if we could get rid of the ${ and }, because users are not interested
in the fact that this is resolved as an expression.
This should make it better to read too.
When I started with Maven I never had the feeling I was passing
system-properties, so I doubt that this is the right name.
I was passing something like goal-arguments...
-Robert
Op Tue, 01 May 2012 20:12:07 +0200 schreef Hervé BOUTEMY
<[email protected]>:
+1 for your analysis
"argument" for "command line argument": I understand the logic, I find it
better than "expression" effectively, but I'm not convinced that it is
much
explicit.
I'm not convinced by "value" either: your analysis is perfectly right
"property"? "system-property"?
considering than when there is an expression that is not simply a
reference to
a system property for command line definition, it's probably that it
should
have been defined as default-value instead
has someone any experience of a real world use case where the value is
not
simply ${a.system.property}?
And why not replace expression="${my.property}" with system-
property="my.property"? Which could generated the exact same plugin
descriptor, but would simply be a lot more explicit for developer
writing his
annotation
Regards,
Hervé
Le mardi 1 mai 2012 19:53:37 Robert Scholte a écrit :
I don't know the numbers, but I'm assuming that 99 out of 100 times the
expression is filled with a command line argument.
I can imagine why the name 'expression' was used: it must contain
exactly
one expression.
But that's from the technical perspective.
We've all seen the threads where users try to use the name of the
configuration-property name instead of the expression as argument for a
plugin.
The name 'expression' doesn't trigger the users.
From that perspective I hope that 'argument' is clearer.
I don't think that 'value' would be much better for users, but maybe
it's
also a matter of improving the goal docs generation.
-Robert
Op Mon, 30 Apr 2012 22:19:14 +0200 schreef Hervé BOUTEMY
<[email protected]>:
> probably a good occasion to improve usability
>
> but I don't understand "argument", even if I can't find any good
> proposition
>
> value? as opposed to default-value?
>
> any other idea around?
>
> Regards,
>
> Hervé
>
> Le lundi 30 avril 2012 09:31:27 Robert Scholte a écrit :
>> Hi,
>>
>> "expression" has always caused a lot of confusion for plugin-users.
>> Should this be a moment to rename it to something like "argument"?
>>
>> -Robert
>>
>> Op Sat, 28 Apr 2012 23:23:11 +0200 schreef <[email protected]>:
>> > Author: olamy
>> > Date: Sat Apr 28 21:23:10 2012
>> > New Revision: 1331837
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1331837&view=rev
>> > Log:
>> > [MPLUGIN-189] add java 5 annotations support to mark Mojo sources
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
