On Wed, Jul 18, 2012 at 2:44 PM, Jason van Zyl <[email protected]> wrote: > The only thing I would check, because I can't remember off the top of my > head, is if the merge code is generated or if it's a utility class. If it's a > utility class then it probably doesn't much matter but would be nice back in > Modello. If it's generated it should go back to Modello (or Plexus, not sure > where it is actually).
the merging code is in plexus-utils. the only problem with moving there is that InputLocation is defined in maven, not plexus. :( modello generated code is only the parser that needs to create the inputlocation tree, not sure exactly but the parser also delegates to some non-generated class in either modello or plexus when creating the Xpp3Dom tree(s). Milos > > Modello is here: https://github.com/sonatype/modello > > Plexus Utils is here: https://github.com/sonatype/plexus-utils > On Jul 18, 2012, at 8:37 AM, Milos Kleint wrote: > >> On Wed, Jul 18, 2012 at 2:34 PM, Jason van Zyl <[email protected]> wrote: >>> Is your use case providing the user the path to navigate back to the >>> originating model/element from the effective POM? Or is it refactoring the >>> POM or both? >> >> to show where it's defined and allow jumping to the location. haven't >> thought about refactoring yet. >> >> Milos >> >>> >>> On Jul 18, 2012, at 2:32 AM, Milos Kleint wrote: >>> >>>> Hello, >>>> >>>> I've created issue https://jira.codehaus.org/browse/MNG-5309 along >>>> with a prototype patch to tackle the issue of missing InputLocation >>>> elements for Xpp3Dom part of the model, that's mostly plugin's >>>> configuration.. >>>> >>>> The patch replaces the plexus-utils Xpp3Dom code for merging with one >>>> that additionally merges the InputLocation trees. The key used in >>>> InputLocation's children is the Xpp3Dom object itself. Appears to be >>>> working even though the hashcode and equals methods for Xpp3Dom change >>>> based on content *and* child nodes. >>>> issue 1: do we attempt to push the location aware merging code back >>>> down to plexus-utils or keep it in maven? >>>> >>>> issue2: the populating of InputLocation tree is not covered so far, >>>> just proof of concept post-processing after the Xpp3 reader creates >>>> the Model object tree. Should this go to modello? where are the >>>> current master sources of modello? >>>> >>>> Thank you >>>> >>>> Milos Kleint >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>> >>> Thanks, >>> >>> Jason >>> >>> ---------------------------------------------------------- >>> Jason van Zyl >>> Founder & CTO, Sonatype >>> Founder, Apache Maven >>> http://twitter.com/jvanzyl >>> --------------------------------------------------------- >>> >>> Our achievements speak for themselves. What we have to keep track >>> of are our failures, discouragements and doubts. We tend to forget >>> the past difficulties, the many false starts, and the painful >>> groping. We see our past achievements as the end result of a >>> clean forward thrust, and our present difficulties as >>> signs of decline and decay. >>> >>> -- Eric Hoffer, Reflections on the Human Condition >>> >>> >>> >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > Thanks, > > Jason > > ---------------------------------------------------------- > Jason van Zyl > Founder & CTO, Sonatype > Founder, Apache Maven > http://twitter.com/jvanzyl > --------------------------------------------------------- > > A man enjoys his work when he understands the whole and when he > is responsible for the quality of the whole > > -- Christopher Alexander, A Pattern Language > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
