if the diff is included in the mail then that would be sufficient imo. But I'd rather ping back to board if this is fine.
If the mail is created with git-format-patch and later applied via git-am then this should be as fine as JIRA imo. Still a JIRA reference should be there for referencing in the release notes, etc. My main point is that a hell lot of github forks have a pretty unclear provenance and a rather questionable quality :/ I really like github for some stuff, but nowadays it somehow looks like a dustbin which didn't get cleaned up since ages ;) LieGrue, strub ----- Original Message ----- > From: Kristian Rosenvold <kristian.rosenv...@gmail.com> > To: Maven Developers List <dev@maven.apache.org>; Mark Struberg > <strub...@yahoo.de> > Cc: > Sent: Wednesday, December 5, 2012 10:53 AM > Subject: Re: apache/maven-3 at Github > > 2012/12/5 Mark Struberg <strub...@yahoo.de>: >> But to make this more clear, we will only accept pull changes if they come > along with an identical JIRA with the diff. You also must make sure that you > are > the only one who has changed something in the contribution. It's way to easy > to fake author Ids on github... >> >> The committer which applies the patch or signs off the pull request must > make sure that all IP is cleared. > > We've been through this before ;) > > I understand that the important thing is that there's a clear record > of authorship and a clear record of submission ? > > As far as I understand the pull request being sent to the dev@ list is > a record of submission. It's a bit of a pity the > actual diff isn't included in the pull request mail; I wonder why the > asf script that dispatches these mails doesn't include fetch the > actual diff ? > > As for clear record of authorship I have tended to assume that > committer emails must clearly show an email address or a name that > would match a name in a jira. As for /who/ that person is, we have > never really known anyway. I am unsure if we should downright reject > commits/pull requests that do not sufficiently identify the author, > even if they reference a jira? > > Since I rebase and amend most submissions, I tend to add the details > about the jira submitter to the extent they > do not match the author info in git. > > As for the *actual* diff attached to a jira; do we really need those ? > Wouldn't it be sufficient if the mail from pull included the diff ? > > Kristian > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
