GitHub user mcculls opened a pull request:
https://github.com/apache/maven-integration-testing/pull/3
MNG-5446: AM/PM inconsistency in mng-3827 and mng-3864 ITs?
See https://jira.codehaus.org/browse/MNG-5446 - Maven appears to ignore the
PM setting when parsing "2008-11-09 11:59:03.0 PM". This is because the Plexus
DateConverter has historically used 'HH'='Hour in day (0-23)' to parse the
hours instead of 'hh'='Hour in am/pm (1-12)'. The parsed date-time is therefore
written back out as "2008-11-09 11:59:03" instead of "2008-11-09 23:59:03".
If this behaviour is wrong and can be safely fixed then updating the ITs to
use "2008-11-09 11:59:03.0 AM" would avoid future IT failures if/when the Date
conversion is finally fixed.
If however the old behaviour should be maintained then no change is
required in the ITs. (I'd like to know because I'm doing some refactoring of
the Sisu-Plexus internals to improve re-use and consistency.)
BTW, does anyone happen to know of plugins whose goals/mojos have Date
parameters?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcculls/maven-integration-testing MNG-5446
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-integration-testing/pull/3.patch
----
commit 41d47ab9351095909ea5220ac84201a4f9d5dc15
Author: Stuart McCulloch <[email protected]>
Date: 2013-03-04T22:58:08Z
Old plexus date configurator ignores AM/PM setting; fixing this breaks
unrelated ITs that happen to expect '2008-11-09 11:59:03.0 PM' to be converted
to '2008-11-09 11:59:03' so avoid this by changing the input string in those
ITs to use 'AM' instead.
----
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
