No problem, Stuart fixed it up. All good. On Mar 18, 2013, at 12:18 PM, ceki <c...@qos.ch> wrote:
> sorry about the unused INSTANCE field in SimpleLoggerFactory which is > unnecessarily confusing. Just got rid of it: > > https://github.com/qos-ch/slf4j/commit/192f47034eda752 > > On 18.03.2013 19:59, mcculls wrote: >> GitHub user mcculls opened a pull request: >> >> https://github.com/apache/maven/pull/4 >> >> Fix call to SimpleLoggerFactory.reset method >> >> Use LoggerFactory to make sure we get the right instance to reset, as >> SimpleLoggerFactory.INSTANCE is not actually used by slf4j-simple's >> StaticLoggerBinder (instead it has its own SINGLETON field to hold the >> logger factory). >> >> Can now remove temporary reflection workaround. >> >> You can merge this pull request into a Git repository by running: >> >> $ git pull https://github.com/mcculls/maven slf4j-simple-reset >> >> Alternatively you can review and apply these changes as the patch at: >> >> https://github.com/apache/maven/pull/4.patch >> >> ---- >> commit bae4b5a5613737c99ae99eca7d5ea7bbed99419a >> Author: Stuart McCulloch <mccu...@gmail.com> >> Date: 2013-03-18T18:57:04Z >> >> Fix call to SimpleLoggerFactory.reset method (use LoggerFactory to make >> sure we get the right instance to reset, as SimpleLoggerFactory.INSTANCE is >> not actually used by slf4j-simple's StaticLoggerBinder) and remove temporary >> reflection workaround >> >> ---- > > > -- > Ceki > 65% of statistics are made up on the spot > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > Thanks, Jason ---------------------------------------------------------- Jason van Zyl Founder & CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl --------------------------------------------------------- happiness is like a butterfly: the more you chase it, the more it will elude you, but if you turn your attention to other things, it will come and sit softly on your shoulder ... -- Thoreau
