See also https://jira.codehaus.org/browse/MRELEASE-594

Some background info: the maven-release-plugin ensures that the *used* dependencies of the project are final. If a dependency is *defined* as SNAPSHOT in dependencyManagement but it isn't used, the release is considered stable. However, if this is a parent-pom it would be nice to verify dependencyManagement as well.

If you have a complete patch + integration or unittest, attach it to MRELEASE-594, I can have a look at it.

Robert

Op Tue, 27 Aug 2013 19:25:33 +0200 schreef Konrad <[email protected]>:

Hello everyone,

I was wondering why the resolution of snapshots in the dependency section is implemented but the resolution of snapshots in the dependencyManagement section is not. There is also a @TODO comment regarding this at CheckDependencySnapshots.java line 148.

As far as I can see the resolution of dependencyManagement snapshots can be implemented the same way as dependency snapshots:

         try {

// This is the same as 'project.createArtifacts( artifactFactory, null, null );' for snapshot dependencies // but it uses project.getDependencyManagement().getDependencies() instead of project.getDependencies()
             @SuppressWarnings( "unchecked" )
Set<Artifact> dependencyManagementArtifacts = MavenMetadataSource.createArtifacts( this.artifactFactory, project.getDependencyManagement().getDependencies(), null, null, project );

checkDependencies( originalVersions, releaseDescriptor, artifactMap, dependencyManagementArtifacts );

         } catch ( InvalidDependencyVersionException e ) {
throw new ReleaseExecutionException( "Failed to create dependency-management artifacts", e );
         }


Best regards

Konrad


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to