Le jeudi 31 octobre 2013 07:54:25 Tony Chemit a écrit :
> On Thu, 31 Oct 2013 00:20:27 +0100
> 
> "Bernd Eckenfels" <[email protected]> wrote:
> > Am 31.10.2013, 00:06 Uhr, schrieb Olivier Lamy <[email protected]>:
> > > On 31 October 2013 08:01,  <[email protected]> wrote:
> > >> +    @Parameter( property = "maven.rar.skip" )
> > >> +    private boolean skip;
> > 
> > Does it make sense to add a expression="${maven.rar.skip}" (or maybe
> > ${skipMavenRar}?). Especially the skip function is usefull from the
> > command line.
> 
> Hum I follow the *convention* used by other plugins :
> 
> maven.test.skip
> maven.javadoc.skip
> maven.install.skip
> ...
in fact, the convention is about the parameter name
but for the way to configure the parameter (ie parameter vs expression), it's 
more than a convention, it's a change in plugin-tools in version 3.0, done 
when adding Java 5 annotations support: expression was the parameter name 
provided as javadoc annotations, but it was changed in Java 5 annotations:
1. expanded to not need ${} in http://jira.codehaus.org/browse/MPLUGIN-194
2. renamed to property in http://jira.codehaus.org/browse/MPLUGIN-196

And this means that @Parameter( property = "maven.rar.skip" ) makes the 
property available from the command line, no problem

Regards,

Hervé


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to