good idea: if we do deprecate plugin-tools' @component, no need to create new annotations, but better reuse
thanks you for the idea Hervé Le samedi 8 février 2014 11:27:19 Igor Fedorenko a écrit : > Why not use jsr330 or plexus annotations and just deprecate plugin-tools > @Component annotation? > > -- > Regards, > Igor > > On 2/8/2014, 11:24, Hervé BOUTEMY wrote: > > ok, so the other confusing part in plugin-tools is to have a @Component > > annotation equivalent to Plexus' @Requirement and not Plexus' @Component > > (which defines a component, not uses it) > > > > so perhaps we should deprecate plugin-tools @component/@Component in favor > > of a new @requirement/@Requirement > > > > (notice this part doesn't have anything to do with the hack for pseudo > > component) > > > > WDYT? > > > > Hervé > > > > Le samedi 8 février 2014 17:10:55 Robert Scholte a écrit : > >> If I'm correct, these are all the same: > >> > >> CDI @Inject > >> Plexus' @Requirement > >> Plugin's @Component > >> > >> However, the way MavenSession, MavenProject and MojoExecution are > >> injected > >> isn't done by DI, but by the expression evaluator. > >> > >> Robert > >> > >> Op Sat, 08 Feb 2014 17:00:48 +0100 schreef Igor Fedorenko > >> > >> <i...@ifedorenko.com>: > >>> On 2/8/2014, 9:56, Hervé BOUTEMY wrote: > >>>> ok, here the confusion is that there are 2 @Component annotations: > >>>> org.apache.maven.plugins.annotations.Component = plugin-tools > >>>> and > >>>> org.codehaus.plexus.component.annotations.Component = Plexus on Guice > >>>> > >>>> plugin-tools @Component annotation for objects injected by > >>>> PluginParameterExpressionEvaluator causes confusion at plugin-tools > >>>> level > >>> > >>> Can you point me at the code that implements this? I was under > >>> impression that plugin-tools @Component was translated to plexus/guice > >>> requirement at runtime and there was no real difference between the two. > >>> Any special handing of @Component in PluginParameterExpressionEvaluator > >>> should not be necessary in 3.2 and I would like to clean this up. > >>> > >>> -- > >>> Regards, > >>> Igor > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >>> For additional commands, e-mail: dev-h...@maven.apache.org > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
