> On July 8, 2013, 4:09 p.m., Benjamin Hindman wrote: > > I like the simplification. A little context here: we originally used the > > popovers because we wanted to be able to copy the date for searching the > > logs. ;) At this point in time that hasn't really been necessary, so I'm > > fine with shipping this, but we might want to think about other ways to > > easily copy dates (or other cumbersome strings, like IDs) to make it easy > > to search in the logs. > > > > If others have found the popovers useful for log searching please speak up > > now!
I figured copying/pasting was likely the reason behind the popovers and will look at a better solution because of that. Github prints only shortened SHAs for commits and adds a "Copy SHA" button wherever it shows shortened SHAs. I like that approach with the caveat that it requires Flash and therefore would not work on devices that don't support Flash. Thoughts? - Ross ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12283/#review22823 ----------------------------------------------------------- On July 5, 2013, 10:55 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12283/ > ----------------------------------------------------------- > > (Updated July 5, 2013, 10:55 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Dates now use HTML "title" attribute on <abbr> elements to let the browser do > the hover work. Bootstrap already styles <abbr> with a dashed underline. > > This removes the blue color from dates since they are not navigation. > > > Diffs > ----- > > src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67 > src/webui/master/static/framework.html > c3827e886351308dadd61fbe6a7570ad5d3d5110 > src/webui/master/static/frameworks.html > acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182 > src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 > src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d > src/webui/master/static/slaves.html > 508748f16c87a1ad2f3f9f4af33767165b61052c > > Diff: https://reviews.apache.org/r/12283/diff/ > > > Testing > ------- > > Viewed all pages with "isoDate" uses to confirm rendering. > > Hovered over dates in on each page to confirm "title" attribute showed > correct time. > > > Thanks, > > Ross Allen > >
