----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12285/#review22847 -----------------------------------------------------------
Thanks Ross! src/Makefile.am <https://reviews.apache.org/r/12285/#comment46583> We've been including both the minified and un-minified versions of all js libraries in the project, so that developers can use the readable source when debugging the code. Can you add the non-minified version as well? - Ben Mahler On July 5, 2013, 10:57 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12285/ > ----------------------------------------------------------- > > (Updated July 5, 2013, 10:57 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-282 > https://issues.apache.org/jira/browse/MESOS-282 > > > Repository: mesos > > > Description > ------- > > The full version of Angular included two breaking changes: > * $defer was renamed to $timeout > * For route providers, the 'template' key was renamed to 'templateUrl' > > This address one point of MESOS-282: "-Upgrade angular.js (it has breaking > changes from our current version, so non-trivial) to use the full > angular-ui.js" > > > Diffs > ----- > > src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4 > src/webui/master/static/angular-1.0.0rc8.js > 212b111737545d2db3014637f9e5b51f9516db55 > src/webui/master/static/angular-1.0.0rc8.min.js > 414632838071581ab367ea646f07c832be5817c1 > src/webui/master/static/angular-1.0.7.min.js PRE-CREATION > src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67 > src/webui/master/static/controllers.js > f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd > src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8 > > Diff: https://reviews.apache.org/r/12285/diff/ > > > Testing > ------- > > Rendered all pages of the site to confirm routes render as before. > > Clicked popovers and orderable table headers to confirm JS functionality > still works as before. > > > Thanks, > > Ross Allen > >
