> On July 8, 2013, 4:15 p.m., Benjamin Hindman wrote: > > Does this speed up displaying the image? > > > > At some point it would be great to get the new Mesos logo on the page too > > (and possibly update colors to match logo colors). ;) > > Ross Allen wrote: > It can, although in this case the difference is likely on the order of a > few milliseconds. > > If height/width are omitted on an <img> element, the browser reserves no > space for it, a 0px x 0px space, and continues rendering the rest of the page > while it queues the image for download. When it receives enough of the image > file to know its size, it resizes the element to the size of the image, which > in this case will force the browser to reflow and repaint any elements that > come after the <img>. > > Best practice is to always set height/width on image elements when > possible.
+1 to adding the new logo and color scheme! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12286/#review22827 ----------------------------------------------------------- On July 5, 2013, 11 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12286/ > ----------------------------------------------------------- > > (Updated July 5, 2013, 11 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > <img> tags with known height/width should specify height/width attributes so > the browser can reserve space in the layout for them. > > > Diffs > ----- > > src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8 > > Diff: https://reviews.apache.org/r/12286/diff/ > > > Testing > ------- > > Rendered homepage with loading gif. > > > Thanks, > > Ross Allen > >
