> On July 15, 2013, 4:59 p.m., Ben Mahler wrote: > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/JenkinsScheduler.java, > > lines 65-74 > > <https://reviews.apache.org/r/12538/diff/1/?file=321307#file321307line65> > > > > I thought we fixed this inside MesosNativeLibrary.java. Was this done > > outside of MesosNativeLibrary because you needed to set > > MESOS_NATIVE_LIBRARY? > > > > What do you think about adding an overload to the > > MesosNativeLibrary.load() function for doing this work when one knows the > > path: > > > > public static load(String libraryPath);
good call. fixed in a different review. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12538/#review23160 ----------------------------------------------------------- On July 14, 2013, 5:24 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12538/ > ----------------------------------------------------------- > > (Updated July 14, 2013, 5:24 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > jenkins/Makefile.am 9f9ebf4902f1ea8728a27cd7f6a4ef53479087f4 > jenkins/src/main/java/org/jenkinsci/plugins/mesos/JenkinsScheduler.java > 9166e7002269d79f2e097f1014dda0681d8d2ba3 > > Diff: https://reviews.apache.org/r/12538/diff/ > > > Testing > ------- > > make jenkins > > Also tested with a local invocation of Jenkins. > > > Thanks, > > Vinod Kone > >
