----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12701/ -----------------------------------------------------------
Review request for mesos. Repository: mesos-git Description ------- The '$beforeRouteChange' event was renamed to '$routeChangeStart' in v1.0.0rc11[1]. The change was purely a name change for consistency; it still fires at the same time. There's a typo in the Changelog about the new name, but the commit[2] shows the real new name: '$routeChangeStart'. [1] https://github.com/angular/angular.js/blob/9bef436b22f0cd57c294f1db1958f46e64fcfed1/CHANGELOG.md#breaking-changes [2] https://github.com/angular/angular.js/commit/7c2428218893f59c6a4499667488009ca67f3385 Diffs ----- src/webui/master/static/js/controllers.js PRE-CREATION Diff: https://reviews.apache.org/r/12701/diff/ Testing ------- Added 'debugger' statements inside the event listener callbacks to verify first that the '$beforeRouteChange' event was no longer firing and then that the '$routeChangeStart' event _was_ firing after the change. Thanks, Ross Allen
