----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12366/#review23582 -----------------------------------------------------------
Ship it! src/tests/allocator_tests.cpp <https://reviews.apache.org/r/12366/#comment47469> How about moving this up before we create 'frameworkInfo1'? src/tests/allocator_tests.cpp <https://reviews.apache.org/r/12366/#comment47470> Awesome test Thomas! src/tests/allocator_tests.cpp <https://reviews.apache.org/r/12366/#comment47471> Can we put these all in the order we expect them to get done? I.e.,: allocator frameworkAdded sched1 registered sched1 resourceOffers allocator resourcesUnused exec registered exec launchTask sched1 statusUpdate sched1 resourceOfferes // for unused src/tests/allocator_tests.cpp <https://reviews.apache.org/r/12366/#comment47472> Can we put this one above the (sched2, registered)? src/tests/allocator_tests.cpp <https://reviews.apache.org/r/12366/#comment47473> Will this be dispatched before (sched1, resourceOffers) above? src/tests/allocator_tests.cpp <https://reviews.apache.org/r/12366/#comment47474> Again, great test. I think if we move some of this stuff around it will be even more clear! - Benjamin Hindman On July 20, 2013, 12:46 a.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12366/ > ----------------------------------------------------------- > > (Updated July 20, 2013, 12:46 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-505 > https://issues.apache.org/jira/browse/MESOS-505 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/allocator_tests.cpp 1c26d3f > src/tests/allocator_zookeeper_tests.cpp 8b74794 > src/tests/fault_tolerance_tests.cpp 414c648 > src/tests/gc_tests.cpp 1745800 > src/tests/mesos.hpp 5cb5aa2 > > Diff: https://reviews.apache.org/r/12366/diff/ > > > Testing > ------- > > bin/mesos-tests.sh --gtest_break_on_failure --gtest_repeat=1000 > --gtest_filter=*Reservation* > > > Thanks, > > Thomas Marshall > >
