----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11125/#review23724 -----------------------------------------------------------
Ship it! Hmm. can't see the diff for some reason, though the file it complains does exist in the repo http://git.apache.org/mesos.git/objects/af/. Anyhow, if this is just a rebase you can commit it. - Vinod Kone On July 23, 2013, 10:39 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11125/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 10:39 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Terminate executors that aren't needed. > > If we launch an executor and then kill the task immediately after, make > sure we also terminate the executor when there are no other tasks. > > Review: https://reviews.apache.org/r/11125 > > > Diffs > ----- > > src/slave/slave.cpp af1b487f5d8a411fab43985c52c4542c230d40f0 > > Diff: https://reviews.apache.org/r/11125/diff/ > > > Testing > ------- > > Used in production at airbnb. > > > Thanks, > > Brenden Matthews > >
