> On July 25, 2013, 9:23 p.m., Ben Mahler wrote: > > src/webui/master/static/js/controllers.js, lines 456-468 > > <https://reviews.apache.org/r/12880/diff/1/?file=326135#file326135line456> > > > > Can you move this down to where it's used? > > Ross Allen wrote: > I defined them outside the scope of `var update = function() { ... }` > because they don't need access to the `update` function's scope. > > This could actually move outside the Controller's scope as well since it > doesn't need access to anything in that scope either.
Ditto from my previous comment, since they're only being used in one scope. Let's keep it local unless it proves useful for other parts of the code. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12880/#review23874 ----------------------------------------------------------- On July 23, 2013, 8:54 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12880/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 8:54 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Compute framework stats in one iteration > > Rather than iterate over 'frameworks' and 'completed_frameworks' once > to update the slave mappings and a second time to calculate stats for > the frameworks, move that work into a single loop. > > This also removes a 'concat' call that was creating a temporary Array > used to calculate stats once and then thrown away. > > > Diffs > ----- > > src/webui/master/static/js/controllers.js > dae12b61001ff0c7379169242e5d125ef6ca141b > > Diff: https://reviews.apache.org/r/12880/diff/ > > > Testing > ------- > > Rendered /slaves/:id to verify framework stats were still calculated properly. > > > Thanks, > > Ross Allen > >
