----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12619/#review24245 -----------------------------------------------------------
Ship it! Let's add a pthread_kill to avoid the sigtimedwait. This should be "more correct" in the sense that it's less likely we'll swallow process wide signals (but we still might, which is probably okay). 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp <https://reviews.apache.org/r/12619/#comment48052> s/suppressed/suppress/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp <https://reviews.apache.org/r/12619/#comment48057> We should definitely factor out to os/signals.hpp! 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp <https://reviews.apache.org/r/12619/#comment48090> We should just add a PASSERT_* and be done with it. - Benjamin Hindman On July 17, 2013, 1:49 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12619/ > ----------------------------------------------------------- > > (Updated July 17, 2013, 1:49 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-508 > https://issues.apache.org/jira/browse/MESOS-508 > > > Repository: mesos-git > > > Description > ------- > > This is to resolve MESOS-508 by masking SIGPIPE per-thread through a > "Suppressor" abstraction. > > This was the old review: https://reviews.apache.org/r/12146/ > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 5ade4400bf31a4d15ffd0d478ccb0e950199394e > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 27485845848fbf53119c5d0720830e2d5b8acbcf > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 429039644832470f7fd2eac19b213905cc81dcd3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/12619/diff/ > > > Testing > ------- > > ./3rdparty/libprocess/3rdparty/stout-tests > --gtest_filter="OsSendfileTest.sendfile" --gtest_repeat=30000 > --gtest_break_on_failure > > > Thanks, > > Ben Mahler > >
