> On Aug. 2, 2013, 8:05 p.m., Ben Mahler wrote:
> > src/slave/cgroups_isolator.cpp, lines 784-790
> > <https://reviews.apache.org/r/13224/diff/1/?file=334350#file334350line784>
> >
> > Is it possible for the slave to receive duplicate executorTerminated
> > calls now?
the same slave would not get duplicate executorTerminated messages. a restarted
slave might get a executorTerminated message even though the previous slave
received it. we err on the side of caution here. that said, the next review
("don't recover completed executors") avoids even this as much as possible.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13224/#review24557
-----------------------------------------------------------
On Aug. 2, 2013, 6:54 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13224/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 6:54 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Brenden Matthews.
>
>
> Bugs: MESOS-607
> https://issues.apache.org/jira/browse/MESOS-607
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp 0faf7d50d76887cad02267ab11827664a4b63476
> src/tests/slave_recovery_tests.cpp 1871e3ba41e65dcbd4b95779dda068f6a1a2ecb3
>
> Diff: https://reviews.apache.org/r/13224/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
