----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13407/#review24895 -----------------------------------------------------------
Ship it! src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/13407/#comment49061> Not yours, but can you kill this variable? src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/13407/#comment49059> Not yours, but: return true src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/13407/#comment49060> return false - Ben Mahler On Aug. 8, 2013, 5:52 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13407/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2013, 5:52 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-538 > https://issues.apache.org/jira/browse/MESOS-538 > > > Repository: mesos-git > > > Description > ------- > > Instead of master rejecting these resources, the allocator should simply not > offer them. > > > Diffs > ----- > > src/master/hierarchical_allocator_process.hpp > 76465ebf3f9ab9e31e763bb2bc00e22e9c6ee717 > src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df > src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8 > > Diff: https://reviews.apache.org/r/13407/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
