----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13389/#review24932 -----------------------------------------------------------
Ship it! So much nicer! src/tests/reaper_tests.cpp <https://reviews.apache.org/r/13389/#comment49076> s/adopted/re-parented/ Check out benh's diagrams in OsTest.killtree, these would be awesome to have here as well! src/tests/reaper_tests.cpp <https://reviews.apache.org/r/13389/#comment49077> newline s/pid/grandchild/ src/tests/reaper_tests.cpp <https://reviews.apache.org/r/13389/#comment49078> Can you remove this LOG line? We don't do any logging in tests typically, outside of failures. src/tests/reaper_tests.cpp <https://reviews.apache.org/r/13389/#comment49079> s/pid/child/ src/tests/reaper_tests.cpp <https://reviews.apache.org/r/13389/#comment49082> s/pid/child/ - Ben Mahler On Aug. 9, 2013, 3:15 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13389/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2013, 3:15 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-534 > https://issues.apache.org/jira/browse/MESOS-534 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/reaper_tests.cpp d3e11072d5e8f5138210db566eec2d65942bcacd > > Diff: https://reviews.apache.org/r/13389/diff/ > > > Testing > ------- > > sudo ./bin/mesos-tests.sh -j --gtest_filter="ReaperTest.*" > --gtest_repeat=15000 --gtest_break_on_failure --gtest_shuffle > > > Thanks, > > Jiang Yan Xu > >
