> On Aug. 9, 2013, 6:36 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/Makefile.am, line 44 > > <https://reviews.apache.org/r/13387/diff/2/?file=339147#file339147line44> > > > > Thanks for moving this out! Would be great to add read_tests.cpp while > > you're at it :)
So I modified the OsTest.readWriteString to test multi-line text. Couldn't have moved it into a separate file but this method depends on the OsTest fixture to create tmp dir/file. Would be nice to put the fixture base class in a header under stout/tests/os/ but punt it for now? - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13387/#review24934 ----------------------------------------------------------- On Aug. 9, 2013, 3:13 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13387/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2013, 3:13 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-534 > https://issues.apache.org/jira/browse/MESOS-534 > > > Repository: mesos-git > > > Description > ------- > > - Removed os::read(int fd) because it's not used elsewhere. > - Separated os::read()s into os/read.hpp. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 770378d11d30e1e222e418c1839affd9d4ffe8d3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 448739e313bf5127e7e5469dd4090445dc5c5405 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/13387/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
