> On Aug. 13, 2013, 7:28 p.m., Ben Mahler wrote: > > src/slave/status_update_manager.hpp, lines 204-205 > > <https://reviews.apache.org/r/13520/diff/1/?file=340298#file340298line204> > > > > Result of Nothing vs. None Result seems like a subtle distinction to > > make. > > > > On that note, I don't think Result<Nothing> makes sense, since Result > > already has a state for nothing-ness. > > > > How about: > > > > // Returns true iff this update was handled, false if already handled > > (duplicate). > > // Returns an error if ... > > Try<bool> update(const StatusUpdate& update) > > Vinod Kone wrote: > sgtm. thanks. fixed.
Thanks! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13520/#review25088 ----------------------------------------------------------- On Aug. 13, 2013, 10:49 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13520/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 10:49 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-640 > https://issues.apache.org/jira/browse/MESOS-640 > > > Repository: mesos-git > > > Description > ------- > > Refactored the StatusUpdateStream API a bit to make it easy to distinguish > duplicates from errors. > > > Diffs > ----- > > src/slave/status_update_manager.hpp > da927606dea63b62d99baac529a3fe371f2767ba > src/slave/status_update_manager.cpp > ffd47369e49f711f984787cd3710f7b4dd5b29ce > src/tests/status_update_manager_tests.cpp > 6473478a283d19f991143710bcf551e298bd6916 > > Diff: https://reviews.apache.org/r/13520/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
