----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13554/#review25222 -----------------------------------------------------------
Ship it! Would love to see a diff of docs/Upgrades.md combined with changes like this (since this enforces an upgrade sequence: upgrade executor driver -> upgrade slave, right?) src/slave/slave.hpp <https://reviews.apache.org/r/13554/#comment49521> Can you document what an empty pid here signifies (given this is used as a helper function in addition to the handler)? src/slave/slave.cpp <https://reviews.apache.org/r/13554/#comment49520> Can you use the boolean operator or != operator instead? if (pid) { } if (pid != UPID()) { } - Ben Mahler On Aug. 15, 2013, 9:17 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13554/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2013, 9:17 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-644 > https://issues.apache.org/jira/browse/MESOS-644 > > > Repository: mesos-git > > > Description > ------- > > Slave now acknoweledges status updates sent by unknown executors. > > > Diffs > ----- > > src/exec/exec.cpp 1a0dd074598933b402136be940b3cfff64476e96 > src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce > src/slave/slave.cpp b41f2bd6ec0cdf00b0ff166d5089a984b2707ac2 > src/tests/fault_tolerance_tests.cpp > d74463fa5b9c6181634b38e91650b03a75c170d4 > > Diff: https://reviews.apache.org/r/13554/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
