----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13755/#review25449 -----------------------------------------------------------
i will wait for your other changes before giving it a ship it. thanks for taking this on! src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13755/#comment49860> s/the reaper reaps the terminated executor/the command executor's reaper reaps the task and sends TASK_KILLED/ ? - Vinod Kone On Aug. 23, 2013, 12:11 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13755/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2013, 12:11 a.m.) > > > Review request for mesos, Vinod Kone and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > This test was hanging for me, it appeared the reaper was not given a chance > to reap after the killTask was issued. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 314786060cbf16144feb7ea8057e24c3d2595f31 > > Diff: https://reviews.apache.org/r/13755/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
