----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13789/#review25494 -----------------------------------------------------------
Ship it! Did you manually verify this works as you expect? src/slave/slave.hpp <https://reviews.apache.org/r/13789/#comment49944> unsigned int src/slave/slave.cpp <https://reviews.apache.org/r/13789/#comment49945> s/while/during/ Consider: 4 errors encountered during recovery vs Errors encountered during recovery: 4 src/slave/state.hpp <https://reviews.apache.org/r/13789/#comment49946> unsigned int here and elsewhere - Ben Mahler On Aug. 24, 2013, 12:35 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13789/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2013, 12:35 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jie Yu. > > > Bugs: MESOS-663 > https://issues.apache.org/jira/browse/MESOS-663 > > > Repository: mesos-git > > > Description > ------- > > Number of recovery errors ignored while in non-strict mode are now exposed. > > > Diffs > ----- > > src/slave/http.cpp 073d0923febf697dec2a9bbfa6e3b243bcab7316 > src/slave/slave.hpp aca7f031fb987d1c522c634680dd2c56623b4753 > src/slave/slave.cpp 563a0997b1fec7c827bd6950c449fa651ce008f0 > src/slave/state.hpp 7e887058b7fd01913e51a195e6240ce625df2016 > src/slave/state.cpp aab8d0b090c7b821fe55aec640d37d1aab9fe7ed > > Diff: https://reviews.apache.org/r/13789/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
