-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14328/#review26371
-----------------------------------------------------------
The diff is impossible to look at, but you can grep for the content ".table
thead th{vertical-align:bottom}". That is the selector that was removed.
- Ross Allen
On Sept. 25, 2013, 3:48 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14328/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2013, 3:48 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-702
> https://issues.apache.org/jira/browse/MESOS-702
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Aligned column headers to top for consistent rendering.
>
> "vertical-align: bottom;", which is Bootstrap's default for <th>
> elements, renders inconsistently when the cell contains enough content
> to wrap.
>
> Nuking the style lets ".table th, .table td" win with
> "vertical-align: top;" and renders consistently.
>
>
> Diffs
> -----
>
> src/webui/master/static/css/bootstrap-2.3.2.min.css
> b6428e695860151f82076e87810fe2d133339c2a
>
> Diff: https://reviews.apache.org/r/14328/diff/
>
>
> Testing
> -------
>
> Rendered home.html in Chrome and in Firefox, shrank window small enough for
> content to wrap, and confirmed "vertical-align: top;" rendered consistently.
>
>
> File Attachments
> ----------------
>
> Before style change
> https://reviews.apache.org/media/uploaded/files/2013/09/25/before.png
> After style change
> https://reviews.apache.org/media/uploaded/files/2013/09/25/after.png
>
>
> Thanks,
>
> Ross Allen
>
>
