----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14098/#review26392 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On Sept. 24, 2013, 7:24 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14098/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2013, 7:24 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-690 > https://issues.apache.org/jira/browse/MESOS-690 > > > Repository: mesos-git > > > Description > ------- > > Need to copy 'frameworks' when looping through them and shutting them down > because shutdownFramework() can mutate 'frameworks'. > > > Diffs > ----- > > src/slave/slave.cpp 21b57f98dd11ceecac81e353c1b0058f11dd12b2 > > Diff: https://reviews.apache.org/r/14098/diff/ > > > Testing > ------- > > make check > > ./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest*" > --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle > > > Thanks, > > Vinod Kone > >
