> On Sept. 25, 2013, 7:09 a.m., Ben Mahler wrote:
> > src/sasl/auxprop.cpp, lines 61-63
> > <https://reviews.apache.org/r/14310/diff/3/?file=356661#file356661line61>
> >
> > How about: CHECK(properties != NULL) << ...
>
> Benjamin Hindman wrote:
> How about: CHECK_NOTNULL(properties) << ...
>
> ;)
CHECK_NOTNULL() does not expose a stream ;)
"Since this macro returns the given pointer, this is very useful in constructor
initializer lists.
struct S {
S(Something* ptr) : ptr_(CHECK_NOTNULL(ptr)) {}
Something* ptr_;
};
Note that you cannot use this macro as a C++ stream due to this feature. Please
use CHECK_EQ described above to log a custom message before aborting the
application."
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14310/#review26367
-----------------------------------------------------------
On Sept. 24, 2013, 8:26 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14310/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2013, 8:26 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Initial SASL based authentication support. (I'll likely also be cleaning some
> stuff up as I deal with compilation issues with different libsasl2* versions.)
>
>
> Diffs
> -----
>
> configure.ac 96ac7a81311e9f3765bd54e078368566a3cc33ca
> include/mesos/mesos.proto 8f845cc9b7cd491622cb29a69f6909170510a664
> src/Makefile.am 3eae9642b639e78f101e7fe580aa803beadbebda
> src/messages/messages.proto 4d400c2d8f6ecb9f7cf8635b2a98341206bbb6c5
> src/sasl/authenticatee.hpp PRE-CREATION
> src/sasl/authenticator.hpp PRE-CREATION
> src/sasl/auxprop.hpp PRE-CREATION
> src/sasl/auxprop.cpp PRE-CREATION
> src/tests/sasl_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14310/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
