----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13757/#review26745 -----------------------------------------------------------
Ship it! src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/13757/#comment52056> Do we need the slave in this test? Killing it would make this test much simpler! src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/13757/#comment52057> you can kill this if there is no slave. src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/13757/#comment52058> s/,/ to the failed over scheduler;/ s/ensure/ensures/ src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/13757/#comment52059> .Times(0) on the next line. src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/13757/#comment52061> you can kill these too if there is no slave. - Vinod Kone On Oct. 4, 2013, 6:15 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13757/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 6:15 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-488 > https://issues.apache.org/jira/browse/MESOS-488 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-659. > > > Diffs > ----- > > src/master/master.cpp ce8365f082a5f96ef64e33e526cb5047dff52127 > src/tests/fault_tolerance_tests.cpp > 10e52c401476eb8416361de49b8e4061bb7ac4f3 > > Diff: https://reviews.apache.org/r/13757/diff/ > > > Testing > ------- > > Added a test that catches this case when not fixed. > > > Thanks, > > Ben Mahler > >
