----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14662/#review27109 -----------------------------------------------------------
Ship it! No tests? ;) 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/14662/#comment52769> Looks like the return code is not needed, can you inline it? if (::utime(path.c_str(), NULL) == -1) { return ErrnoError(); } - Ben Mahler On Oct. 16, 2013, 12:38 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14662/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2013, 12:38 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Needed for this for a subsequent review to do gc based on modtimes. > > Also fixed 'touch()' to more closely resembled the touch utility. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 728122ec9eeb903723daa9294e258fed2141bea6 > > Diff: https://reviews.apache.org/r/14662/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
