----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14669/#review27106 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/14669/#comment52767> This is a bit tricky. If an offer appears more than once in offerIds, it will try to remove same offer more than once which causes a fault. src/python/native/mesos_scheduler_driver_impl.cpp <https://reviews.apache.org/r/14669/#comment52766> This check was copied from the tasks list processing just below. PyList_GetItem only returns NULL when i is out of bounds, so we should be able to remove both checks. src/sched/sched.cpp <https://reviews.apache.org/r/14669/#comment52764> Each task will be added |offerIds| times if add_tasks remains in the loop. - Niklas Nielsen On Oct. 17, 2013, 6:10 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14669/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 6:10 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Running tasks on more than one offer belonging to a single slave can be > useful in situations with multiple out-standing offers. > > This patch extends the usual launchTasks() to accept a vector of OfferIDs. > The previous launchTasks (accepting a single OfferID) has been kept for > backward compatibility, but this now calls the new launchTasks() with a > one-element list. > This also applied for the JNI and python interfaces, which accepts both > formats as well. > > Offers are verified to belong to the same slave and framework, before > resources are merged and used. > > > Diffs > ----- > > include/mesos/scheduler.hpp fa1ffe8 > src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 9869929 > src/java/src/org/apache/mesos/MesosSchedulerDriver.java ed4b4a3 > src/java/src/org/apache/mesos/SchedulerDriver.java 93aaa54 > src/master/master.hpp 9f5e25b > src/master/master.cpp 1bf5d47 > src/messages/messages.proto a5dded2 > src/python/native/mesos_scheduler_driver_impl.cpp 059ed5d > src/sched/sched.cpp 824b4b7 > src/tests/master_tests.cpp feea541 > > Diff: https://reviews.apache.org/r/14669/diff/ > > > Testing > ------- > > A new test, MasterTest.LaunchCombinedOfferTest, has been added. > This test ensures that: > 1) Multiple offers can be used to run a single task (requesting the sum of > offer resources). > 2) No offers can appear more than once in offer list. > 3) Offers cannot span multiple slaves. > > $ make check > ... > [ RUN ] MasterTest.LaunchCombinedOfferTest > [ OK ] MasterTest.LaunchCombinedOfferTest (3043 ms) > ... > > > Thanks, > > Niklas Nielsen > >
