----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14616/#review27263 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/14616/#comment53102> I think this would read more nicely as: async(...) .then(recover) .then(_recover) .onAny(__recover) The reason I like "_recover" style naming is that it avoids polluting the namespace: I immediately know that it's a continuation. In the case of "reconnect", I need to figure out where it's called (it's not immediately obvious that it's a continuation of recover(), or that it's not for "reconnect" to the Master, or some other component). I'll leave this up to you, just wanted to share the reason why I prefer continuations to be named based this way. src/slave/slave.cpp <https://reviews.apache.org/r/14616/#comment53105> indentation src/slave/slave.cpp <https://reviews.apache.org/r/14616/#comment53106> space before ( - Ben Mahler On Oct. 17, 2013, 9:55 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14616/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 9:55 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-732 > https://issues.apache.org/jira/browse/MESOS-732 > > > Repository: mesos-git > > > Description > ------- > > Improvements: > > --> Reading from disk is now done in a separate libprocess (process::async > ftw :)) > > --> Streamlined recovery code. > > > Diffs > ----- > > src/slave/slave.hpp 22fb74b71a0f52d9d67b92ecc286fa8d350e41a4 > src/slave/slave.cpp debb2f4ce05fbfec450197e68bc8a0c78f1d0adf > src/slave/state.cpp 5208e4e8eaaea5aea9e23a6ac7d09822e15433b2 > src/slave/status_update_manager.hpp > 1f55f868548ae79052856e0255097b447ffe7573 > src/slave/status_update_manager.cpp > b6afeb18d3bd97ca4f4238b2ffbf6bd7de8e6888 > src/tests/slave_recovery_tests.cpp 02dd25f3427562373d0396669c0f010e1dae67c6 > > Diff: https://reviews.apache.org/r/14616/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
