----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15112/#review27942 -----------------------------------------------------------
3rdparty/libprocess/include/process/shared.hpp <https://reviews.apache.org/r/15112/#comment54387> An alternative strategy would be to just return an Owned<T>(NULL)? What's your reasoning on these semantics instead? A comment or different semantics please. 3rdparty/libprocess/src/tests/shared_tests.cpp <https://reviews.apache.org/r/15112/#comment54385> In the interest in keeping this consistent, can we s/sp/shared/ and s/sp2/shared2/ and s/op/owned/ please? - Benjamin Hindman On Oct. 31, 2013, 7:01 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15112/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2013, 7:01 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang > Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/shared.hpp faa11cc > 3rdparty/libprocess/src/tests/shared_tests.cpp e520b4f > > Diff: https://reviews.apache.org/r/15112/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
