> On Oct. 31, 2013, 7:09 p.m., Ben Mahler wrote: > > Looking good! > > > > Can you also add the status setting code to the slave? > > > > With the current patch if a Master fails over the transitions are lost. > > If the slave also stores the transitions, the master will know the > > transitions from the Task sent by the slave during re-registration. > > > > May be good to add Ross to this review for the webui related bits.
One issue is that the column sorting broke with this patch, and my javascript skills are not quite epic enough to figure it out. > On Oct. 31, 2013, 7:09 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 1427-1435 > > <https://reviews.apache.org/r/14434/diff/5/?file=371838#file371838line1427> > > > > We should wipe the 'data' and 'message' as they may be arbitrarily > > large. > > > > s/TaskStatus */TaskStatus* / Ben Hindman suggested we keep this. I'll add him on the review. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14434/#review27939 ----------------------------------------------------------- On Oct. 26, 2013, 1:48 a.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14434/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2013, 1:48 a.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Added list of TaskStatuses to Task message. > > Task now includes repeated task status with timestamps. This permits > caltulating the start/finish time for tasks (among other things). > > To support this, a timestamp was added to the TaskStatus message which > is also passed to frameworks when there are state transitions. > > Review: https://reviews.apache.org/r/14434 > > > Diffs > ----- > > include/mesos/mesos.proto d45ee5ea1287f925332968b7247b21f72ba38b13 > src/common/protobuf_utils.hpp 19a49ab1cb212b454394b78ffedeb9a7eb6b8964 > src/exec/exec.cpp 4a598f52bd9f97eeb14d9700e05281ccc1650c14 > src/master/http.cpp f2a535a002f07784db724f6fdedfb26b271d6327 > src/master/master.cpp 1147cc6ebd9a2d18c3b58fa103e6348f9d623438 > src/messages/messages.proto a5dded2c0f3f88a5f7d789ccde6e59f68880374b > src/webui/master/static/framework.html > 6e5cd9f9e48597c7894d6381377c8a291014e8f3 > src/webui/master/static/frameworks.html > 7c243d47d80e7c74fcac938d012b91b67b995490 > > Diff: https://reviews.apache.org/r/14434/diff/ > > > Testing > ------- > > `make check`, tested in staging, and manual web UI testing. > > > Thanks, > > Brenden Matthews > >
