----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15144/#review27951 -----------------------------------------------------------
Ship it! Is there anyway to alert to the user that this slave is no longer valid and/or has failed? Maybe a TODO to do that in the future? - Benjamin Hindman On Oct. 31, 2013, 8:11 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15144/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2013, 8:11 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-650 > https://issues.apache.org/jira/browse/MESOS-650 > > > Repository: mesos-git > > > Description > ------- > > Redirected navigation to framework page if slave was gone. > > If an invalid slave ID is used in the redirect controller, redirect the > request to either the homepage or the frameworks page. > > Fixes MESOS-650 > > > Diffs > ----- > > src/webui/master/static/js/controllers.js > 33dbc5de0b19b7b0f790929aea42018a1c757ed7 > > Diff: https://reviews.apache.org/r/15144/diff/ > > > Testing > ------- > > > Thanks, > > Ross Allen > >
