[ 
https://issues.apache.org/jira/browse/MESOS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ross Allen closed MESOS-650.
----------------------------

    Resolution: Fixed

Fix committed to master:

https://reviews.apache.org/r/15144/

> SlaveExecutorRerouterCtrl does not handle missing slave.
> --------------------------------------------------------
>
>                 Key: MESOS-650
>                 URL: https://issues.apache.org/jira/browse/MESOS-650
>             Project: Mesos
>          Issue Type: Bug
>          Components: webui
>            Reporter: Benjamin Mahler
>            Assignee: Ross Allen
>            Priority: Minor
>             Fix For: 0.16.0
>
>
> Saw this while testing the webui manually:
> There was a slave that was removed from the master, and it's tasks still had 
> the Sandbox link in the webui.
> <snip>
>   mesosApp.controller('SlaveExecutorRerouterCtrl',
>       function($http, $location, $routeParams, $scope, $window) {
>     var pid = $scope.slaves[$routeParams.slave_id].pid;
>     var hostname = $scope.slaves[$routeParams.slave_id].hostname;
>     var id = pid.substring(0, pid.indexOf('@'));
>     var host = hostname + ":" + pid.substring(pid.lastIndexOf(':') + 1);
> </snip>
> Clicking on the link caused the following:
> TypeError: Cannot read property 'pid' of undefined
>     at new mesosApp.controller.$scope.slave_id 
> (http://smfd-aki-27-sr1.devel.twitter.com:5050/static/js/controllers.js:756:51)
>     at d 
> (http://smfd-aki-27-sr1.devel.twitter.com:5050/static/js/angular-1.0.7.min.js:28:174)
>     at Object.instantiate 
> (http://smfd-aki-27-sr1.devel.twitter.com:5050/static/js/angular-1.0.7.min.js:28:304)
>     at 
> http://smfd-aki-27-sr1.devel.twitter.com:5050/static/js/angular-1.0.7.min.js:52:239
>     at <error: illegal access>
>     at Object.e.$broadcast 
> (http://smfd-aki-27-sr1.devel.twitter.com:5050/static/js/angular-1.0.7.min.js:90:281)
>     at 
> http://smfd-aki-27-sr1.devel.twitter.com:5050/static/js/angular-1.0.7.min.js:82:323
>     at h 
> (http://smfd-aki-27-sr1.devel.twitter.com:5050/static/js/angular-1.0.7.min.js:78:33)
>     at h 
> (http://smfd-aki-27-sr1.devel.twitter.com:5050/static/js/angular-1.0.7.min.js:78:33)
>     at 
> http://smfd-aki-27-sr1.devel.twitter.com:5050/static/js/angular-1.0.7.min.js:78:266
>  
> We should probably not show the sandbox link when the slave ID is unknown to 
> the master.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to