----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15138/#review27977 -----------------------------------------------------------
Maybe a TODO to use the new Shared -> Owned upgrade code from Jie that is now committed? We could use that here to avoid storing the pointer as a member variable! With lambdas it would be really clean too ;) - Ben Mahler On Oct. 31, 2013, 11:09 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15138/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2013, 11:09 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-787 > https://issues.apache.org/jira/browse/MESOS-787 > > > Repository: mesos-git > > > Description > ------- > > See bug for details. > > > Diffs > ----- > > src/sched/sched.cpp 3049096a7aeaea6c1063a1bbcef119517daa236c > > Diff: https://reviews.apache.org/r/15138/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >