----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15653/#review29124 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/15653/#comment56255> How about Try<vector<double> > instead? We typically return values by return value rather than function parameter. - Vinod Kone On Nov. 18, 2013, 7:19 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15653/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 7:19 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This patch includes a wrapper to get system load averages in uptime(1) > format. This is used by an upcoming patch which expose these averages > over master and slave stats.json endpoints. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > f6bbf5e00a810affd8cb6f828d1f306dc8bf3051 > > Diff: https://reviews.apache.org/r/15653/diff/ > > > Testing > ------- > > make check and functional testing with endpoints. > > > Thanks, > > Niklas Nielsen > >
