----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16226/#review30299 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/16226/#comment58127> I know we're only supporting GET & POST now but perhaps it would be better to make the bool isGet a enum with the different verbs we support. We could just keep it at GET & POST for now but if were to ever say at PUT, just as an example, the churn we would take here would be reduced quite a bit. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/16226/#comment58007> NIT: Drop the space. src/master/repair_coordinator.hpp <https://reviews.apache.org/r/16226/#comment58135> Perhaps add comment to explain what this does? src/tests/master_tests.cpp <https://reviews.apache.org/r/16226/#comment58137> It may be worthwhile to add tests where each observe POST sends a request missing at least one of the keys. I know the check today is a key size check but it we alter that later then having a test to verify this could be useful. - Jeff Currier On Dec. 12, 2013, 11:45 p.m., Charlie Carson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16226/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2013, 11:45 p.m.) > > > Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-880 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-880 > > > Repository: mesos-git > > > Description > ------- > > add an observe endpoint to master. add a stubbed RepairCoordinator. > > > also reordered the existing routes so they are alphabetical > > add a post method to the libprocess library > > added test / modified master_tests to allow for a MockRepairCoordinator > ^refactored two methods which were nearly identical into a common path so > that I didn't make it triplicate > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 5bdd520c9e0bcc0a2d3a4554cc4ced99dcf78b51 > 3rdparty/libprocess/src/process.cpp > 2d193b13cde92a061b02f903a5d6471ff90cb12a > src/Makefile.am 5f211a244f6f64aef4ababebdb542b40d6086b0b > src/local/local.cpp 83a7f913afb1441e9137c7fcec8fd81815714905 > src/master/http.cpp d7cd89f0a3446f4c2e65ecd259544149bf92faf8 > src/master/main.cpp b1e45766281c5ea0b8a3cee89e390ea60a97c5e4 > src/master/master.hpp 6c168a2cdbd8343516cb47adceaff70c3d46690b > src/master/master.cpp cb8e613b31f39329d61a490f5d3f74fd44ffb08c > src/master/repair_coordinator.hpp PRE-CREATION > src/master/repair_coordinator.cpp PRE-CREATION > src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108 > src/tests/master_tests.cpp d34450bf84704b224f4e2dbc61ce100b33d14027 > src/tests/mesos.hpp b1239a653e515115a71e436c79b2d11db4a209f9 > src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364 > > Diff: https://reviews.apache.org/r/16226/diff/ > > > Testing > ------- > > new tests to verify the end point is passing data to the mock repair > coordinator coorectly. > > make check to verify that existing tests are passing > > > Thanks, > > Charlie Carson > >
